RTN15f #438
RTN15f #438
Conversation
| var resumed = false | ||
| waitUntil(timeout: testTimeout) { done in | ||
| client.connection.once(.Connected) { _ in | ||
| channel.publish(nil, data: "message") { _ in |
There was a problem hiding this comment.
I am not sure I follow hot his method is called twice, can you explain?
There was a problem hiding this comment.
Is called twice? Can you clarify? The publish only receives the ACK (callback is called) after the connection has been resumed.
There was a problem hiding this comment.
Maybe I'm wrong. @tcard do you have any suggestion for this one?
There was a problem hiding this comment.
I don't understand @mattheworiordan 's point either. This looks good to me. The message is sent in one transport, which is immediately dropped. The fact that publish's callback is called after the connection is resumed proves that the library resent the message in the new transport.
There was a problem hiding this comment.
Sorry, I misunderstood the code. However, as the spec states that the message is resent on the new transport, can we also include that check so that this test code explains what is happening i.e. it's not that on a new connection the ACK is sent, it's actually an ACK that is received from the message being resent. Do you agree?
There was a problem hiding this comment.
Done bcd8a7e.
|
LGTM (by the way). |
No description provided.