RSL2b #476
Merged
RSL2b #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure what this test is testing. We're not testing: "start must be equal to or less than end and is unaffected by the request direction", "if omitted the direction defaults to the REST API default (backwards)", "limit supports up to 1,000 items", "if omitted the direction defaults to the REST API default (100)". |
|
I tried to cover all the parameters ( |
|
@tcard PTAL |
|
👍 |
|
LGTM. @ricardopereira Any idea about what happens with CI now? There's a ton of "account blocked" errors, wasn't 5663598 supposed to fix that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.