Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presence#history wasn't working (infinite recursion) #51

Merged
merged 1 commit into from
Nov 16, 2015
Merged

Presence#history wasn't working (infinite recursion) #51

merged 1 commit into from
Nov 16, 2015

Conversation

ricardopereira
Copy link
Contributor

  • (Conflicts) Separated base ARTPresence: ARTRealtimePresence and ARTRestPresence
  • ARTRestPresence has base class for ARTRealtimePresence

@ricardopereira
ARTPresence wasn't working. Fixed recursive cicle ...
e1cb005 
 - (Conflicts) Separated base ARTPresence: ARTRealtimePresence and ARTRestPresence
 - ARTRestPresence has base class for ARTRealtimePresence
@ricardopereira ricardopereira mentioned this pull request Nov 13, 2015
Closed
@mattheworiordan
Copy link
Member

This looks good, however I am a bit confused by the naming now. Previously it was something like ARTObject, so ARTClient stood for Ably Real-Time Client, however now it seems we are doubling up on Realtime i.e. ARTRealtimePresence. I realise in Java the realtime class names are prefixed with Realtime, but it does feel a bit odd. Out of interest, just so that I know, what do you think about the classes simply being AblyRealtime* and AblyRest* instead? How difficult would this be to change i.e. are there refactoring tools built into Xcode?

@mattheworiordan mattheworiordan merged this pull request into objc-tests-realtime-attach Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardopereira @mattheworiordan