Sentry. #603
Merged
Sentry. #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To-do: - [ ] Tests. - [ ] Catch signals caused by the library (in progress). - [ ] Send device info with report. - [ ] Get stack trace line numbers to work in Sentry.
This way, crashes happening in them won't be reported, since their stack trace won't contain any Ably method.
State transitions can occur both from WebSockets (which run on their on their own threads) and from user's actions, so they are intrinsically concurrent and need to be explicitly synchronized. The library is still not thread-safe, but it's a start and a big part of achieving at least internal thread-safety.
tcard
added a commit
that referenced
this pull request
May 15, 2017
* WIP: Report crashes to Sentry. To-do: - [ ] Tests. - [ ] Catch signals caused by the library (in progress). - [ ] Send device info with report. - [ ] Get stack trace line numbers to work in Sentry. * Sentry: send device info. * ARTChannels doesn't really have a ARTRest. * Crash reports with (almost) full device info. * Fix ARTRest exception handler on constructor. * ARTRest: don't recover from exceptions in exception-recovering code. * Don't recover from expected exceptions. * Install KSCrash once, on ARTRest's constructor. * ARTSentry: only report crashes from Ably. * Wrap every callback from the user to call asynchronously. This way, crashes happening in them won't be reported, since their stack trace won't contain any Ably method. * Report to Sentry on unexpected message serial. * Use KSCrashAblyFork. * Serialize state transitions in a GCD queue. State transitions can occur both from WebSockets (which run on their on their own threads) and from user's actions, so they are intrinsically concurrent and need to be explicitly synchronized. The library is still not thread-safe, but it's a start and a big part of achieving at least internal thread-safety. * Bring back breadcrumbs. * Bump KSCrashAblyFork version. * Prevent deadlock when dispatch_syncing twice to same queue. * Gzip Sentry reports. * Serialize ARTLog.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.