Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default token TTL to nil, not 60*60. #619

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Default token TTL to nil, not 60*60. #619

merged 1 commit into from
Jul 19, 2017

Conversation

tcard
Copy link
Contributor

@tcard tcard commented Jul 19, 2017

Fixes #618.

Part of ably/docs#303.

@mattheworiordan
Copy link
Member

LGTM, but no test to prevent a regression i.e. make sure the TTL is not set?

@tcard
Copy link
Contributor Author

tcard commented Jul 19, 2017

@mattheworiordan Yes, it's in Auth.swift which GitHub thinks it has too many changes to show the diff.

@mattheworiordan
Copy link
Member

Yes, it's in Auth.swift which GitHub thinks it has too many changes to show the diff.

Oops sorry @tcard! Schoolboy error :)

@tcard tcard merged commit d4f6461 into master Jul 19, 2017
@tcard tcard deleted the 618-nil-ttl branch July 19, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@mattheworiordan mattheworiordan Awaiting requested review from mattheworiordan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcard @mattheworiordan @SimonWoolf