Reuse connection when receiving an AUTH. #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #622. The test suite has a few broken tests. I don't think they're caused by this change, although I haven't checked. We probably should take a deeper look at them before doing a release.
SimonWoolf
approved these changes
Jul 31, 2017
|
@tcard I am not sure if I missed a previous response (which is quite likely), but given the connection was previously reconnecting and not resuming, are we sure that issue is resolved as well? |
|
@mattheworiordan Yes. Tests for that are passing. |
Ok, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #622.
The test suite has a few broken tests. I don't think they're caused by
this change, although I haven't checked. We probably should take a
deeper look at them before doing a release.