-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage support #639
Carthage support #639
Conversation
- Removed internal Pods for better Carthage support. Now, the setup of the lib for development should include a `carthage bootstrap`.
Tested the CocoaPod and it fails 😖
The framework is named with the name of the Pod (KSCrashAblyFork) in CocoaPods: The framework is named with the name of the project (KSCrash) in Carthage: |
CocoaPod and Carthage are working! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can we merge this then?
Source/ARTWebSocketTransport.m
Outdated
#if COCOAPODS | ||
[self.websocket send:data]; | ||
#else | ||
// https://github.com/facebook/SocketRocket/issues/542 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow :(
@tcard I think so but let them try the branch. Just for sure. |
#637