Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #639

Merged
merged 12 commits into from
Oct 31, 2017
Merged

Carthage support #639

merged 12 commits into from
Oct 31, 2017

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira
Copy link
Contributor Author

ricardopereira commented Oct 20, 2017

Tested the CocoaPod and it fails 😖

target 'AblyTestingPod' do
  use_frameworks!
  pod 'Ably', :path => '~/Repositories/Whitesmith/ably-ios'
end

The framework is named with the name of the Pod (KSCrashAblyFork) in CocoaPods: #import <KSCrashAblyFork/KSCrash.h>

The framework is named with the name of the project (KSCrash) in Carthage: #import <KSCrash/KSCrash.h>

@ricardopereira
Copy link
Contributor Author

CocoaPod and Carthage are working! 🙌

@ricardopereira ricardopereira requested a review from tcard October 20, 2017 09:48
Copy link
Contributor

@tcard tcard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can we merge this then?

#if COCOAPODS
[self.websocket send:data];
#else
// https://github.com/facebook/SocketRocket/issues/542
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow :(

@ricardopereira
Copy link
Contributor Author

@tcard I think so but let them try the branch. Just for sure.

@ricardopereira ricardopereira merged commit 2027ee3 into master Oct 31, 2017
@ricardopereira ricardopereira deleted the carthage-support branch January 12, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants