-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supported platform to README #693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: The following platforms.
So if someone builds an app embedding this library will that app fail to install on iOS8? Will it run but possibly fail at runtime?
I think a statement about platform support needs to be explicit about what it means for a platform to be unsupported.
@paddybyers Technically I didn't drop the compatibility with iOS8 yet in the configuration. So it will "work", as in compile and not throw runtime errors. I am afraid the message in the README can be quite long:
I'd keep the positive version: "we support x, y and z". Or even "this SDK is compatible with iOS9 and above". |
OK, fine. If we later we or customers find things that are broken on earlier versions we can decide whether we explicitly state that it is not compatible with iOS 8, or we have a statement that says something like "some features are not available on earlier iOS versions; see <issue>". |
@paddybyers Improved again the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Fix #692