Push Activation State Machine missing tests #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyboy
reviewed
Jun 12, 2018
| // RSH3g | ||
| context("State WaitingForDeregistration") { | ||
| // RSH3f | ||
| context("State AfterRegistrationUpdateFailed") { | ||
|
|
|
|
||
| let deviceIdentityToken = stateMachine.rest.device.identityTokenDetails?.token.base64Encoded() | ||
|
|
||
| let simulatedError = NSError(domain: ARTAblyErrorDomain, code: 1234, userInfo: nil) |
There was a problem hiding this comment.
This is repeated quite often. I suggest to have a createError() helper function.
| } | ||
| } | ||
| stateMachine.send(ARTPushActivationEventCalledActivate()) | ||
| expect(stateMachine.current).to(beAKindOf(ARTPushActivationStateWaitingForRegistrationUpdate.self)) |
There was a problem hiding this comment.
This is repeated below on line 876
| stateMachine.send(ARTPushActivationEventDeregistrationFailed(error: expectedError)) | ||
| expect(stateMachine.current).to(beAKindOf(ARTPushActivationStateWaitingForDeregistration.self)) | ||
| expect(deactivatedCallbackCalled).to(beTrue()) | ||
| } |
There was a problem hiding this comment.
I think this is missing a test for RSH3g3b
| } | ||
|
|
||
| // RSH5 | ||
| it("event handling sould be atomic and sequential") { |
funkyboy
force-pushed
the
push-activation-state-machine-missing-tests
branch
from
7163969 to
ca29f73
Compare
|
Rebased on |
|
Failing tests https://travis-ci.org/ably/ably-ios/builds/403176500 have already been fixed in this PR #708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.