Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in preparing tests for push #733

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Fix race condition in preparing tests for push #733

merged 1 commit into from
Jun 14, 2018

Conversation

funkyboy
Copy link
Contributor

Channel subscriptions started before all the devices were successfully registered

paddybyers
paddybyers approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@funkyboy funkyboy merged commit 8e18711 into push Jun 14, 2018
@funkyboy funkyboy deleted the fix-race-condition-in-setup-of-push-tests branch June 14, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardopereira ricardopereira ricardopereira approved these changes

@paddybyers paddybyers paddybyers approved these changes

@mattheworiordan mattheworiordan Awaiting requested review from mattheworiordan

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@funkyboy @paddybyers @ricardopereira