Add cd2c #742
Merged
Add cd2c #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| client.connection.once(.connected) { _ in | ||
| let transport = client.transport as! TestProxyTransport | ||
| let firstConnectionDetails = transport.protocolMessagesReceived.filter{ $0.action == .connected }[0].connectionDetails | ||
| expect(firstConnectionDetails!.maxMessageSize).to(equal(16384)) // Sandbox apps have a 16384 limit |
There was a problem hiding this comment.
This is currently failing, right? Because I don't see any change where the connection is sending the current MaxMessageSize to the Realtime system.
There was a problem hiding this comment.
No that's passing. And once this is merged, we can be sure of that value.
There was a problem hiding this comment.
We are already loading that value https://github.com/ably/ably-ios/blob/develop/Source/ARTConnectionDetails.m#L24 It's just not exposed yet in realtime.
ricardopereira
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.