ObjC tests: Review #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bug: Channel had is own clientId string. Changed to readonly property (proxy of auth.clientId) - Bug: when we copy a ClientOptions, the tokenDetails were always instanciated - Bug: ARTRealtimeChannel wasn't overriding the history method
- (Conflicts) Separated base ARTPresence: ARTRealtimePresence and ARTRestPresence - ARTRestPresence has base class for ARTRealtimePresence
…n. Added testRealtimeV2 helper
…e REST api because it needs authentication.
- The REST was using the instance reference of ClientOptions and should copy it to garante
…sing enterClient, updateClient, leaveClient)
- Updated the Connection resume code to use the connectionId instead of the connectionKey
…es the server that it is connected to)
- Added Warning when the response header has a X-Ably-ErrorMessage.
| @@ -182,6 +182,10 @@ - (void)executeRequest:(NSMutableURLRequest *)request completion:(ARTHttpRequest | |||
| } else { | |||
| [self.logger debug:@"%@ %@: statusCode %ld", request.HTTPMethod, request.URL.absoluteString, (long)httpResponse.statusCode]; | |||
| [self.logger verbose:@"Headers %@", httpResponse.allHeaderFields]; | |||
| NSString *headerErrorMessage = httpResponse.allHeaderFields[@"X-Ably-ErrorMessage"]; | |||
| if (headerErrorMessage && ![headerErrorMessage isEqualToString:@""]) { | |||
| [self.logger warn:@"%@", headerErrorMessage]; | |||
There was a problem hiding this comment.
I am going to merge, but could we also log the X-Ably-ErrorCode, if present?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.