Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Realtime clients creation outside the it method scope #811

Merged
merged 2 commits into from
Oct 11, 2018

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira commented Oct 3, 2018

Realtime clients outside the it method scope will be executed anyway if you run an unrelated and specific spec. This can confuse the developer when it’s debugging some Realtime code while expecting a specific behaviour but something else happens.

For example, while debugging an issue and running only one test by using the fit function, I expected 1 initialisation of ARTRealtime and I got 6!

Related with #758.

Realtime clients outside the `it` method scope will be executed anyway
if you run an unrelated and specific spec. This can confuse the
developer when it’s debugging some Realtime code while expecting a
specific behaviour but something else happens.
Copy link
Contributor

@funkyboy funkyboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Thanks 👍

Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@paddybyers paddybyers merged commit 7049dd3 into develop Oct 11, 2018
@ricardopereira ricardopereira deleted the fix-minimize-global-vars branch October 11, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants