Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA8b #91

Merged
merged 3 commits into from
Jan 14, 2016
Merged

RSA8b #91

merged 3 commits into from
Jan 14, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@mattheworiordan
Copy link
Member

Partial support, spec says ... which override defaults for Client Auth. There is no test that it overrides any defaults, so you should set those defaults such as clientId in the ClientOptions, and ensure that the options are overriden here.

@ricardopereira
Copy link
Contributor Author

@mattheworiordan Yes you right. But I do not see anything more than the clientId to override.

@mattheworiordan
Copy link
Member

Yes you right. But I do not see anything more than the clientId to override

You can override any defaults, so if after calling authorise with a set of TokenParams (which it supports and uses for defaults for subsequent requests), you can test that not overriding them uses the defaults, and overriding them uses the new TokenParams

@ricardopereira
Copy link
Contributor Author

@mattheworiordan Done

@mattheworiordan
Copy link
Member

LGTM

mattheworiordan added a commit that referenced this pull request Jan 14, 2016
@mattheworiordan mattheworiordan merged commit 652abd5 into master Jan 14, 2016
@ricardopereira ricardopereira deleted the RSA8b branch January 15, 2016 11:09
maratal pushed a commit that referenced this pull request Jul 19, 2023
maratal pushed a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants