Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more browser tests #493

Closed
4 tasks
funkyboy opened this issue Mar 26, 2018 · 3 comments
Closed
4 tasks

Add more browser tests #493

funkyboy opened this issue Mar 26, 2018 · 3 comments
Assignees
Labels
enhancement New feature or improved functionality.

Comments

@funkyboy
Copy link
Contributor

funkyboy commented Mar 26, 2018

Following this discussion about supported platforms let's add more browser tests. The idea is to add older browser versions so we can state which platforms we support with more confidence. Here's a list of candidates:

  • Opera latest
  • Firefox 51
  • Chrome 56
  • Opera 41

cc SimonWoolf paddybyers

┆Issue is synchronized with this Jira Story by Unito

@funkyboy funkyboy added the enhancement New feature or improved functionality. label Mar 26, 2018
@funkyboy funkyboy self-assigned this Mar 26, 2018
@SimonWoolf
Copy link
Member

SimonWoolf commented Mar 26, 2018

The idea is to add older browser versions so we can state which platforms we support with more confidence

Happy to add more platforms if that'd be useful. But to reiterate what I said in the other issue: the set of platform/browser combinations we support will always be vastly more than the set we can possibly test; we shouldn't conflate the two.

Also though -- a failure of ci-travis-all is currently useless as an indication of a regression for a PR, since it always fails due to the compatibility bugs we currently have. So spending time adding more minor variations on chrome versions is really a bit pointless if we're not paying attention to it anyway! Lets get it reliably passing first so it's actually useful -- i.e. fix all the bugs it currently exposes -- then we can start thinking about adding more platforms to it.

@funkyboy
Copy link
Contributor Author

@SimonWoolf I agree we should fix current failing tests before adding more browsers. See this discussion for more details

@owenpearson
Copy link
Member

Closing this as our browser testing setup has moved on quite a bit since this discussion and I'm pretty happy with the range of browsers we currently test on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

3 participants