Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test on CI #574

Closed
ttypic opened this issue Jan 9, 2025 · 2 comments
Closed

Fix failing test on CI #574

ttypic opened this issue Jan 9, 2025 · 2 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@ttypic
Copy link
Contributor

ttypic commented Jan 9, 2025 •
edited by VeskeR
Loading

Couple of tests that checks code status for ably's errors are failing now, because of the latest improvements in error handling on the realtime side, we need to update those tests

see: https://github.com/ably/ably-python/actions/runs/12692448025/job/35377816849 (from #573)
or main branch: https://github.com/ably/ably-python/actions/runs/12712583787/job/35438492237

┆Issue is synchronized with this Jira Task by Unito
@ttypic ttypic added the bug Something isn't working. It's clear that this does need to be fixed. label Jan 9, 2025
@VeskeR
Copy link
Contributor

VeskeR commented Jan 9, 2025

possibly related to ably-cocoa tests failing with pretty much the same error: https://ably-real-time.slack.com/archives/CURL4U2FP/p1736356509105489

@VeskeR VeskeR added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Jan 10, 2025
@VeskeR
Copy link
Contributor

VeskeR commented Feb 14, 2025

Fixed in #583

@VeskeR VeskeR closed this as completed Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed. failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VeskeR @ttypic