You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
authorize() uses different order of arguments in 0.9: TokenParams, then AuthOptions
realtime/connection:
in one of the code snippets realtime.connection.on('connected', new ConnectionStateListener() {
replace 'connected' with ConnectionEvent.connected. A text preceding this snippet must also be changed according to ConnectionState/ConnectionEvent scheme of emitting events
realtime/channel-messages:
In the code snippet regarding encryption this line options.cipher = params;
is wrong (cipher is of wrong type and private). It should be changed to either options.encrypted = true; options.cipherParams = params;
or to ChannelOptions.fromCipherKey method of ChannelOption creation
In "Handling channel errors" section. First sentence. synchronous -> asynchronous
realtime/encryption:
The doc mentions the key should be 128 or 256 bit long. In the implementation 192 is a valid value too. Also for Java 128 bit is default (IMHO because of additional actions required to enable 256-bit crypto in Oracle JRE).
Crypto.getDefaultParam`: we decided against function with such arguments
the code snippet is wrong (same mistake as the one mentioned above in section (3) of this issue)
generateRandomKey: definitely not a Java syntax, code snippet uses withCipher instead of fromCipherKey
io.ably.lib.types.ClientOptions: should read io.ably.types.ChannelOptions, only CipherParams are supported, withCipherKey -> fromCipherKey
io.ably.lib.util.Crypto.CipherParams: default key length for Java is 128, PKCS#7 -> PKCS#5
Some of the issues mentioned above happen in REST sections as well
The text was updated successfully, but these errors were encountered:
authorize()
uses different order of arguments in 0.9:TokenParams
, thenAuthOptions
in one of the code snippets
realtime.connection.on('connected', new ConnectionStateListener() {
replace 'connected' with
ConnectionEvent.connected
. A text preceding this snippet must also be changed according toConnectionState
/ConnectionEvent
scheme of emitting eventsIn the code snippet regarding encryption this line
options.cipher = params;
is wrong (
cipher
is of wrong type and private). It should be changed to eitheroptions.encrypted = true; options.cipherParams = params;
or to
ChannelOptions.fromCipherKey
method ofChannelOption
creationIn "Handling channel errors" section. First sentence. synchronous -> asynchronous
The doc mentions the key should be 128 or 256 bit long. In the implementation 192 is a valid value too. Also for Java 128 bit is default (IMHO because of additional actions required to enable 256-bit crypto in Oracle JRE).
Crypto.getDefaultParam`: we decided against function with such arguments
the code snippet is wrong (same mistake as the one mentioned above in section (3) of this issue)
generateRandomKey: definitely not a Java syntax, code snippet uses
withCipher
instead offromCipherKey
io.ably.lib.types.ClientOptions: should read
io.ably.types.ChannelOptions
, onlyCipherParams
are supported,withCipherKey
->fromCipherKey
io.ably.lib.util.Crypto.CipherParams: default key length for Java is 128,
PKCS#7
->PKCS#5
Some of the issues mentioned above happen in REST sections as well
The text was updated successfully, but these errors were encountered: