Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTN15h: token errors don't cause a connection to fail #67

Open
paddybyers opened this issue May 4, 2018 · 1 comment
Open

RTN15h: token errors don't cause a connection to fail #67

paddybyers opened this issue May 4, 2018 · 1 comment

Comments

@paddybyers
Copy link
Member

paddybyers commented May 4, 2018

RTN15h says:

if the token is renewable, a single attempt to create a new token should be made and a new connection attempt initiated using the new token. If the token creation fails, the next connection attempt fails due to a token error, or the token was not renewable, the connection will transition to the FAILED state ...

It think it is not correct that the connection fails in the case that the token is renewable; this is also inconsistent with RTN14b.

I think this needs to cover two cases separately:

  • if the token is not renewable, then the connection transitions to FAILED;

  • if the token is renewable, then the client immediately attempts to obtain a new token and reconnect; if that attempt fails (either the token renewal fails with a recoverable error, or the connection attempt fails with a token error) then the connection transitions to DISCONNECTED and may retry after the appropriate retry period.

┆Issue is synchronized with this Jira Task by Unito

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 17, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2812

@QuintinWillison QuintinWillison removed their assignment Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants