Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rights on lib/puppet/provider/gms_webhook/github.rb #28

Closed
mvisonneau opened this issue Feb 19, 2016 · 13 comments
Closed

Wrong rights on lib/puppet/provider/gms_webhook/github.rb #28

mvisonneau opened this issue Feb 19, 2016 · 13 comments

Comments

@mvisonneau
Copy link

Hey,

Got this error after upgrading to 1.0.2 :

Error: /File[/opt/puppetlabs/puppet/cache/lib]: Failed to generate additional resources using 'eval_generate': Error 400 on SERVER: Permission denied - /etc/puppetlabs/code/environments/production/modules/gms/lib/puppet/provider/gms_webhook/github.rb

Adding missing read right on others solves it :

chmod o+r /etc/puppetlabs/code/environments/production/modules/gms/lib/puppet/provider/gms_webhook/github.rb

Cheers!

@abrader
Copy link
Owner

abrader commented Feb 20, 2016

@mvisonneau Well, that is lame. My apologies. Will cut another release soon. Thanks for the heads up. Confirmed the permissions issue when I did a puppet module install abrader/gms as well.

@mvisonneau mvisonneau changed the title Wrong writes on lib/puppet/provider/gms_webhook/github.rb Wrong rights on lib/puppet/provider/gms_webhook/github.rb Feb 21, 2016
@mvisonneau
Copy link
Author

No worries, thanks!

@walterheck
Copy link

@abrader can you push a new release for this? It's currently blocking this module from working properly..

@abrader
Copy link
Owner

abrader commented Mar 25, 2016

@walterheck will do today.

@natemccurdy
Copy link
Contributor

natemccurdy commented May 18, 2016

Did this ever get fixed? ...in master?

Still seeing this in the 1.0.2 release.

@djjudas21
Copy link

Still seeing this in 1.0.2 as well. Any chance of a fixed version? Thanks!

@natemccurdy
Copy link
Contributor

If you're using Code Manager and seeing this issue even on 1.0.2, you might be running into a bug where file permissions (mainly the execute bit) don't change on your master when deploying a new version of a module.

The fix for me was to delete the gms module from the code and code-staging directory on my master(s) then redeploy with Code Manager.

That same bug might also affect r10k as well, but I haven't verified that.

@djjudas21
Copy link

I am indeed using r10k

@rjhornsby
Copy link

I'm using r10k. The bug (a minor oversight, really) seems to be in the module itself as packaged on the Forge, not in Puppet or r10k. The zipfile of 1.0.2 from github looks like it has the right permissions, which makes me think the problem is in the package the Forge is supplying.

@mvisonneau's work-around, even if temporary, is the right one: setting the read bit. No exec permissions are needed.

@abrader
Copy link
Owner

abrader commented Jun 8, 2016

@mvisonneau @rjhornsby @djjudas21 @natemccurdy @walterheck Please inspect release 1.0.3 for similar permission issues. I inspected tarball prior to upload to Forge and confirmed all were set correctly.

@djjudas21
Copy link

@abrader 1.0.3 seems to work for me, thanks!

@rjhornsby
Copy link

Please inspect release 1.0.3 for similar permission issues. I inspected tarball prior to upload to
Forge and confirmed all were set correctly.

1.0.3 looks like that fixed it. Thanks!

@mvisonneau
Copy link
Author

@abrader works for me as well ! Closing the issue then, thanks for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants