Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize course times diplay #237

Closed
thdebay opened this issue Jan 30, 2021 · 0 comments · May be fixed by #266
Closed

Optimize course times diplay #237

thdebay opened this issue Jan 30, 2021 · 0 comments · May be fixed by #266
Labels
enhancement New feature or request good-first-issue up-for-grabs

Comments

@thdebay
Copy link
Collaborator

thdebay commented Jan 30, 2021 •
edited
Loading

Things have already been improved a lot thanks to previous PRs, but it can still be better.

Instead of showing this:
Mon 9:00 - 5:00 | Tue 9:00 - 5:00 | Wed 9:00 - 5:00 | Thu 9:00 - 5:00 | Fri 9:00 - 5:00

we could show:
Mon - Fri 9:00 - 5:00

See code in model Course@getCourseTimesAttribute()
@thdebay thdebay linked a pull request Dec 19, 2021 that will close this issue
Optimize course time display group by day and times #266
Open
rm-yakovenko added a commit to rm-yakovenko/academico that referenced this issue Mar 29, 2022
@rm-yakovenko
Fix: Optimize course times display
69ba452 
academico-sis#237
@rm-yakovenko rm-yakovenko mentioned this issue Mar 29, 2022
Open
rm-yakovenko added a commit to rm-yakovenko/academico that referenced this issue Mar 29, 2022
@rm-yakovenko
Fix: Optimize course times display
e99b07e 
academico-sis#237
rm-yakovenko added a commit to rm-yakovenko/academico that referenced this issue Mar 29, 2022
@rm-yakovenko
Fix: Optimize course times display
b48f787 
academico-sis#237
@thdebay thdebay closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-first-issue up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize course time display group by day and times iphadey/academico
1 participant
@thdebay