Can't convert integer value to Value struct. invalid type: integer -9223372036854776000 as i128

[eddiezhou1]

code:

#[derive(Serialize, Deserialize, PartialEq, Debug)]
struct Demo {
    val_string: String,
    val_i128: i128,
    val: Value,
}
#[test]
fn test_serde_yaml() -> Result<(), serde_yaml::Error> {
    let yaml = "
        val_string: 123
        val_i128: -9223372036854776000
        val: -9223372036854776000
    ";
    let values: Demo = serde_yaml_ng::from_str(yaml).unwrap();
    Ok(())
}

output:

thread 'test_serde_yaml' panicked at src/main.rs:78:54:
called `Result::unwrap()` on an `Err` value: Error("val: invalid type: integer `-9223372036854776000` as i128, expected any YAML value", line: 4, column: 14)

[acatton]

There are multiple issues here:

• Numbers are implemented as an 64-bit integer under the hood.
• 128-bit integers are not implemented as number type

I feel that this should be fixed the right way. Meaning we should be able to de-serialize a 128 bit integer. This involves a little bit of work, as I don't want to implement number as 128bit integer, therefore doubling the cost of numbers.

On the other side, if you don't need to de-serialize numbers that fit on more than 64 bits, we could do one of the two things:

• You could move to i64 and call it a day
• I could do a quick and dirty fix, which would make your code not crash, but it wouldn't be right (= it would overflow)

Otherwise, I'll ask you to wait for when I find the time to refactor numbers.rs. What do you think?

[eddiezhou1]

Alright, I believe the issue should be addressed properly, and I am prepared to wait for your solution. However, if you have the time to implement a quick fix in a new branch, and I can use it locally as a crate, it would be more beneficial.

[eddiezhou1]

I did a quick and dirty fix as my local crate.

[Mingun]

Could you provide the arbitrary_precision feature like serde-json did? When it is active, internally use big numbers to store numbers.

[acatton]

Could you provide the arbitrary_precision feature like serde-json did? When it is active, internally use big numbers to store numbers.

This is a great idea. I'll take a jab at it when I find the time.