Updates CloudFormation mapper to support additional resources #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cft name for param is: AWS:ApiGateway::Stage.MethodSetting singular name
gaurav-gogia
requested review from
cesar-rodriguez,
patilpankaj212 and
kanchwala-yusuf
cesar-rodriguez
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 78.59% 77.72% -0.88%
==========================================
Files 239 244 +5
Lines 6724 6800 +76
==========================================
Hits 5285 5285
- Misses 1111 1187 +76
Partials 328 328
|
patilpankaj212
suggested changes
Jan 24, 2022
pkg/mapper/iac-providers/cft/config/autoscaling-launch-configuration.go
Outdated
Show resolved
Hide resolved
pkg/mapper/iac-providers/cft/config/autoscaling-launch-configuration.go
Outdated
Show resolved
Hide resolved
- nil check on metadataopitons - base64 check on userdata
patilpankaj212
previously approved these changes
Jan 24, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
cesar-rodriguez
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CFT - TF Mapper
This update brings in following resources into CFT - TF Mapper
The update also fixes a typo in one of the existing maps:
Name of resource in CFT uses the singular word
setting