Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds e2e test scenarios for help and scan command #564

Merged
merged 9 commits into from
Mar 3, 2021

Conversation

patilpankaj212
Copy link
Contributor

  1. added test policies and iac files
  2. added tests for help command
  3. added some tests for scan command
  4. fix - incorrect attribute name 'file/folder' in xml output

@patilpankaj212 patilpankaj212 marked this pull request as draft February 23, 2021 11:51
2. initials tests for scan command
@patilpankaj212 patilpankaj212 force-pushed the e2e-scan branch 2 times, most recently from 5e6622c to e2722e6 Compare February 23, 2021 17:26
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #564 (4e75257) into master (bbe97ce) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
- Coverage   77.32%   77.25%   -0.07%     
==========================================
  Files          97       98       +1     
  Lines        2381     2387       +6     
==========================================
+ Hits         1841     1844       +3     
- Misses        398      400       +2     
- Partials      142      143       +1     
Impacted Files Coverage Δ
pkg/results/types.go 100.00% <ø> (ø)
pkg/iac-providers/providers.go 100.00% <100.00%> (ø)
pkg/downloader/getter.go 86.36% <0.00%> (-1.52%) ⬇️
pkg/config/global.go 92.30% <0.00%> (ø)
pkg/utils/dir.go 60.00% <0.00%> (ø)

2. remove unused iac files and golden outputs
@patilpankaj212 patilpankaj212 force-pushed the e2e-scan branch 2 times, most recently from b47d2cd to ef05fbc Compare February 26, 2021 17:40
1. rule filtering
2. resource skipping
3. remote types
@patilpankaj212 patilpankaj212 marked this pull request as ready for review February 26, 2021 18:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kanchwala-yusuf kanchwala-yusuf merged commit bda153e into tenable:master Mar 3, 2021
@patilpankaj212 patilpankaj212 deleted the e2e-scan branch April 7, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants