Update route53LoggingDisabled.rego to ignore private zones #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! The commit include changes to go.sum and go.mod, was that intentional? if not, perhaps rebase? |
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
- Coverage 78.13% 78.08% -0.06%
==========================================
Files 103 104 +1
Lines 2570 2596 +26
==========================================
+ Hits 2008 2027 +19
- Misses 420 422 +2
- Partials 142 147 +5
|
…/github.com/matt-slalom/terrascan into route53-private-dns-zone-cannot-use-logging
Ooops. My bad. Should be fixed now, @amirbenv |
gaurav-gogia
suggested changes
Mar 22, 2021
pkg/policies/opa/rego/aws/aws_route53_query_log/route53LoggingDisabled.rego
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
harkirat22
approved these changes
Mar 23, 2021
gaurav-gogia
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS module route53LoggingDisabled erroneously requires CloudWatch logging for a private Route 53 zone. Per the documentation, query logging only works when the Route53 hosted zone is public.
See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/route53_query_log
and
https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/query-logs.html?console_help=true#query-logs-configuring