-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancancan is still used instead of CanCan. Didn't we revert the cancancan? #43
Comments
@acesuares We reverted it in a project but not in the gem. |
Oh yes. So in the gem it takes from CanCanCan and in new apps from your fork of CanCan 2.0 (!), in old projects from my fork of CanCan 2.0. I got really stuck today but fixed it :-) |
gem 'cancan', :git => 'https://github.com/acesuares/cancan.git', :branch => '2.0' in other: gem 'cancan', :git => 'https://github.com/ortegacmanuel/cancan.git', :branch => '3.0' and in new apps: |
@acesuares hi! I did an exploration about this and my conclusion is that we shoudn't revert cancancan. We should keep using it in the inline_forms gem. Look CanCan is not longer maintained, you can check it in its repo https://github.com/ryanb/cancan. So, my proposal is to keep CanCanCan in the inline_forms gem, the only problem we have currently with CanCanCan is the lack of Permissions on Specific Resource Attributes. The good news is that they are alredy working on it and most probably in the next major release they will introduce it. So, what we do about our current projects needing definition of permissions on specific resource attributes? We do as we did with Papiamentu app, we install our customized version of CanCan. I find this is a better solution than reverting cancancan, it is not good adding gems not maintained. Please, let me know what you think |
Cancancan is still used instead of CanCan. Didn't we revert the cancancan?
The text was updated successfully, but these errors were encountered: