Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOP Installer #47

Open
ortegacmanuel opened this issue Sep 27, 2018 · 1 comment
Open

OOP Installer #47

ortegacmanuel opened this issue Sep 27, 2018 · 1 comment

Comments

@ortegacmanuel
Copy link
Contributor

I saw all the installer changes and besides all they are important, I think we should introduce OOP as a priority. Currently the installer is one long file. It should be a class with different methods and included modules, this way we could organize everything better.

I'm thinking about something like this: https://github.com/thredded/thredded_create_app/blob/master/lib/thredded_create_app/generator.rb#L65

This is highly coupled with all the installer changes and I think it should be a good move before/along with the changes you listed.
@ortegacmanuel
Copy link
Contributor Author

@acesuares please, let me know what you think about this? please explore this link

@ortegacmanuel ortegacmanuel changed the title OOP Intaller OOP Installer Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ortegacmanuel