Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Vec3,vec4 Color Picker #13

Open
willstall opened this issue Jan 18, 2019 · 15 comments
Open

Feature Request: Vec3,vec4 Color Picker #13

willstall opened this issue Jan 18, 2019 · 15 comments

Comments

@willstall
Copy link

I use this plugin every single day for my Glsl daily and just love it. The one thing I'm really missing is the color picker from glslCanvas.....I also love the float sliders, but hey....I just love the color picker more.

Would there be any chance of integrating a color picker?

@leocb
Copy link
Contributor

leocb commented Jan 23, 2019

We all want this feature, believe me!
Currently VSCode does not support inline HTML/JS so we can't do this.. yet
There are some discussion about this (microsoft/vscode#3220 and microsoft/vscode#66493) and a PR that may be what we need (microsoft/vscode#66418)

@actarian
Copy link
Owner

@willstall @leocb this functionality has been implemented and will be shipped with the next release of the extension. it essentially use DocumentColorProvider from the vscode Api

@willstall
Copy link
Author

yooooooooooooooooooooo.....that's amazing news!!!

@leocb
Copy link
Contributor

leocb commented Jan 24, 2019

Nice! this will be a good workaround (tough not perfect because thebookofshaders's pickers are awesome) I guess this will do while we wait for the vscode features I linked to. I think we should still leave this issue opened(?)

@actarian
Copy link
Owner

@willstall @leocb feature added to last release. let's keep it opened waiting for code inset feature.

@willstall
Copy link
Author

Got it working. Gonna give this a week or two and drop feedback in here =)

@willstall
Copy link
Author

I'm loving this so far....

@willstall
Copy link
Author

https://code.visualstudio.com/api/extension-guides/webview

Could this help for making a float component?

@leocb
Copy link
Contributor

leocb commented Jun 28, 2019

The feature you linked only displays webviews on a separate tab (some examples are: this GL canvas extension and the markdown preview), I looked into using it, but the user experience is just terrible and slow, the pickers need to be placed in-line or over the code to be useful in any way.

What we need is the code inset feature, that is the vscode#66418 PR I mentioned above, and that is still under development.

@willstall
Copy link
Author

Ahhh yeah.... Figured as much. I got there following that link and threw it in real quick. I does look like some progress on that inset feature has been made in the last few weeks. I saw something in my searching about it

@willstall
Copy link
Author

Screen Shot 2019-07-11 at 12 53 58 PM

Hey guys! Does this help at all? Looks like inset Webview's at a line number

@leocb
Copy link
Contributor

leocb commented Jul 11, 2019

Yes, that's the inset feature we're waiting for, it's in beta test on the Insiders build of vscode

@actarian
Copy link
Owner

🎉 Huray!

@err123
Copy link

err123 commented Aug 24, 2021

Wow i love this

@kei-arc
Copy link

kei-arc commented Aug 30, 2021

Is there a way to turn off this feature?
In my case, this harms the readability a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants