Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CA Cert to Docker sidecar #397

Closed
Carus11 opened this issue Mar 17, 2021 · 2 comments
Closed

Add CA Cert to Docker sidecar #397

Carus11 opened this issue Mar 17, 2021 · 2 comments

Comments

@Carus11
Copy link
Contributor

Carus11 commented Mar 17, 2021

Hello,
In my github action I am trying to run a docker login command to login to a private container registry. This registry's certificate's CA Certificate needs to be imported to the image of the docker sidecar container.

  • Would the best way to go about this to be to extend docker:dind and install my own certificates?
  • Is there a parameter in the RunnerDeployment I can use to overwrite the image that the docker sidecar uses?
    • In the helm chart there is dindSidecarRepositoryAndTag, however I have installed the kubectl way (kustomize managed cluster)

Thanks

@callum-tait-pbx
Copy link
Contributor

see #393 for details but basically you want to pass in to the manager the --docker-image flag with your unique dind image

@mumoshu mumoshu added enhancement New feature or request and removed enhancement New feature or request labels Mar 23, 2021
@stale
Copy link

stale bot commented May 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 22, 2021
@stale stale bot closed this as completed Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants