Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows that relied on a tag for versioning no longer work #85

Closed
lamont opened this issue Dec 3, 2019 · 5 comments
Closed

workflows that relied on a tag for versioning no longer work #85

lamont opened this issue Dec 3, 2019 · 5 comments

Comments

@lamont
Copy link

lamont commented Dec 3, 2019

Yesterday I had a anothrNick/github-tag-action based workflow which incremented the last tag on master upon PR-merge. (I use that tag during the terraform apply to tag AWS resources with whatever version of my repo) This morning's changes for V2 appears to always checkout with --no-tags, which breaks that workflow. From the V2 PR changes, I don't see how I can use the V2 actions/checkout and retain the last tag. In the meantime I'll pin actions/checkout to yesterday's version so my workflows work again

@lightswitch05
Copy link

I too am using tags, pulling them in manually with git fetch --tags

@ericsciple
Copy link
Contributor

@lamont rather than yesterdays version, consider binding to actions/checkout@v1 (basically yesterdays version, but will get future updates for the v1 channel)

@lamont
Copy link
Author

lamont commented Dec 3, 2019

Thank you @ericsciple, I'd bound to v1.2.0 but will change to v1 as per your suggestion.

@ericsciple
Copy link
Contributor

@lamont regarding the tags... we made perf improvements for the v2 version so that only a single commit is fetched. However another advantage of the v2 version is that it makes it easier to script authenticated git commands (auth token persisted in the git config). So as @lightswitch05 mentioned you can git fetch --tags to get all of the tags. hth and sorry for the inconvenience.

@lamont
Copy link
Author

lamont commented Dec 6, 2019

Thanks for the followup (and work!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants