Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The action assumes github.com #53

Closed
sadovnikov opened this issue May 3, 2023 · 3 comments
Closed

The action assumes github.com #53

sadovnikov opened this issue May 3, 2023 · 3 comments

Comments

@sadovnikov
Copy link

We use GitHub Enterprise Server and therefore GH uses a different hostname.

Seems the action does not use locations from the github.context but assumes github.com.

2023-05-03T12:40:34.4208205Z ##[error]HTTP Status 401 for request POST https://api.github.com/repos/platform/vs86957-go-test/dependency-graph/snapshots
2023-05-03T12:40:34.4209980Z ##[error]Response body:
{
  "message": "Bad credentials",
  "documentation_url": "https://docs.github.com/rest"
}
2023-05-03T12:40:34.4210878Z ##[error]Bad credentials
2023-05-03T12:40:34.4729810Z ##[error]HttpError: Bad credentials
    at /runner/_work/_actions/actions/go-dependency-submission/v1/webpack:/go-dependency-submission/node_modules/@github/dependency-submission-toolkit/dist/index.js:4235:1
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
@juxtin
Copy link
Contributor

juxtin commented May 12, 2023

Looks like this is better solved in the dependency-submission-toolkit, specifically by adding baseUrl here. See the octokit docs for the options reference.

@lseppala
Copy link
Contributor

We will update dependency-submission-toolkit to fix this issue and then update this Action. We will close this issue when we confirm the fix. Thank you for reporting!

@hmaurer
Copy link
Contributor

hmaurer commented May 23, 2023

This was resolved by github/dependency-submission-toolkit#32, shipped in dependency-submission-toolkit >= v1.2.5. We updated dependency-submission-tookit to v1.2.10 in #47 but did not release a new version of the action. I released v1.0.3 just now: https://github.com/actions/go-dependency-submission/releases/tag/v1.0.3. Upgrading to v1.0.3 should resolve the issue.

@hmaurer hmaurer closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants