-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate sbt into setup-java
or create a new one called setup-sbt
for better support for self-hosted runners 🚀
#266
Comments
Why wouldn't you use https://github.com/dwijnand/sbt-extras for this, similar to how it is typically done in Gradle projects (using the Gradle wrapper script)? |
We have already used a script, like the one you linked. This issue refers to native github actions, but thanks for sharing anyway 👍 |
Hello @dimisjim. Thank you for your report. We do not plan to add functionality in the setup-java action to install sbt. The main purpose of the setup-java action is to install java from available distributions. Could you please check existing actions for sbt ? |
@dimisjim sbt has been added to the by-default-installed softwares of the latest OS versions supported in Github Actions (see https://github.com/actions/virtual-environments#available-environments for the OS versions):
|
+1 it would be interesting to integrate the sbt cache like mvn or gradle https://github.com/actions/cache/blob/main/examples.md#scala---sbt |
@fmeriaux Go for it. 😉 Lines 23 to 36 in f69f00b
|
done #302 |
FYI: https://github.com/coursier/cache-action handles sbt cache (also Mill, Ammonite, and is highly configurable). |
Hello everyone. The new version was released with sbt caching support. |
Hello everyone. I'm going to close the issue because the new version with sbt caching support was released and the major tag was updated. If you have any concerns feel free to ping us. |
Description:
Seems that, currently, sbt is part of the github-provided virtual environments, and not in
setup-java
Justification:
Having sbt installed in the jackfan.us.kg-provided runners is a bit problematic for users of self-hosted runners as it causes false expectations for this
setup-java
action, given that sbt is actually something that needs java to function. Thus installation of it would make much more sense to happen in this action, or alternatively in another new one, calledsetup-sbt
orsetup-scala
(actually, an action with this name already exists and depends on a not very stable project, called jabba, see olafurpg/setup-scala#48 for more background on this)I had previously opened: actions/starter-workflows#1309 which I have now closed, to keep comms here exclusively.
Our current, in-house workaround is to use sdkman.io to install everything manually in our self-hosted runners.
Are you willing to submit a PR?
Yes
The text was updated successfully, but these errors were encountered: