Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-versions only packaging x64, include arm64 please #857

Closed
jpike88 opened this issue Sep 20, 2023 · 8 comments
Closed

node-versions only packaging x64, include arm64 please #857

jpike88 opened this issue Sep 20, 2023 · 8 comments
Assignees
Labels
feature request New feature or request to improve the current logic needs eyes

Comments

@jpike88
Copy link

jpike88 commented Sep 20, 2023

I have arm runners and use an LTS version of node included in https://github.com/actions/node-versions/releases. But I use arm64, only x64 builds are in there.

Please include both architectures so I can leverage fast downloads.

Thanks

@jpike88 jpike88 added feature request New feature or request to improve the current logic needs triage labels Sep 20, 2023
@jpike88 jpike88 changed the title node-versions only packaging x64, include arm please node-versions only packaging x64, include arm64 please Sep 20, 2023
@nikolai-laevskii
Copy link
Contributor

Thanks for creating an issue! We will look into and come back to you with the details!

@bennet-esyoil
Copy link

Currently experiencing this:

Attempting to download 18...
Not found in manifest. Falling back to download directly from Node
Acquiring 18.18.0 - arm64 from https://nodejs.org/dist/v18.18.0/node-v18.18.0-linux-arm64.tar.gz
aborted
Waiting 18 seconds before trying again

could be resolved by including arm versions directly?

@jpike88
Copy link
Author

jpike88 commented Sep 22, 2023

Much appreciated. As you can see it's a very annoying wait!

Screenshot 2023-09-22 at 14 59 12

@jpike88
Copy link
Author

jpike88 commented Sep 27, 2023

this issue is quite acute. is there an official workaround for this (maybe I can cache the binary myself), while still leveraging this step?

@dustin-engstrom
Copy link

I think we have to wait for this issue to be addressed.

actions/runner-images#5631

@jpike88
Copy link
Author

jpike88 commented Oct 18, 2023

Why wait for that?? Buildjet has offered arm64 runners for quite some time now, it’s those runners that I’m using. Not sure why waiting for github to catch up is necessary here.

@dustin-engstrom
Copy link

Why wait for that?? Buildjet has offered arm64 runners for quite some time now, it’s those runners that I’m using. Not sure why waiting for github to catch up is necessary here.

My comment is based on the way this setup-node action currently works. If you look here you'll see that it pulls a manifest file of current node-versions from this file in a separate repo. But that file does not currently contain any arm64 targets; which is why the action always ends up downloading directly from Node instead. The issue I linked in my comment is a request to add arm64 targets to that manifest file in the other repo.

Feel free to propose other workarounds though. I just thought it would be helpful to know that there's an issue raised already at the source of this problem.

@aparnajyothi-y
Copy link
Contributor

fix merged and arm64 packages supporting for linux and windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Development

No branches or pull requests

5 participants