Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release master for Ruby 3 compatibility #225

Closed
nsommer opened this issue Feb 8, 2021 · 16 comments
Closed

Release master for Ruby 3 compatibility #225

nsommer opened this issue Feb 8, 2021 · 16 comments

Comments

@nsommer
Copy link
Contributor

nsommer commented Feb 8, 2021

Would you consider bumping the version and doing a release of master? ActiveHash currently does not run with Ruby 3, but it was already fixed on master (f644831).

@nsommer
Copy link
Contributor Author

nsommer commented Mar 12, 2021

@kbrock @syguer any chance you would release soonish? 🙂

@kbrock
Copy link
Collaborator

kbrock commented Jul 26, 2021

Hi @syguer -- are you the one to push these changes live?
Anything other people need to do to help with this effort?

@aknicol
Copy link

aknicol commented Nov 3, 2021

Have these issues for Ruby 3 been resolved? I'm still receiving Undefined method 'arity' on my model definitions.

@aknicol
Copy link

aknicol commented Nov 5, 2021

As I mentioned I'm still having issues, my code follows the example in the docs almost exactly, I have:

class Person < ActiveRecord::Base

  extend ActiveHash::Associations::ActiveRecordExtensions
  belongs_to_active_hash :country

on the next line,

belongs_to :surname, optional: true

I get the error undefined method `arity' for {:optional=>true}:Hash

@cath-oneill
Copy link

Finally upgrading to Ruby 3, and running into the same issues. It does appeared to be fixed for my use-case both in master (f644831) as @nsommer pointed out, and @gazayas' offered another possible fix in his PR. Anything that can be done to help get the work that's already been done released?

@Sixeight
Copy link

Sixeight commented Jan 5, 2022

@zilkey Could you release a new version? Current version has some problem with Ruby 3.x.
Or, How about an idea create new organization for this library to maintain the library by community.
Thanks for the great library!

@Sixeight
Copy link

Sixeight commented Jan 5, 2022

https://github.com/active-hash had been created. but the new version has not been released. does anyone has publishable permission?

@aknicol
Copy link

aknicol commented May 11, 2022

Has there been any progress on this?

@yujideveloper
Copy link
Contributor

v3.1.1 has been released that supports Ruby 3.x.
https://rubygems.org/gems/active_hash/versions/3.1.1

@neocoin
Copy link

neocoin commented Feb 9, 2023

@yujideveloper

Please release version v3.1.2.

I've made some monkey patches to make active_hash work in Ruby 3.2 and Rails 7.

For example, Ruby 3.2 must need these commits.

00f9811
bb11159

@yujideveloper
Copy link
Contributor

@neocoin
Sorry, I don't have commit and release permissions.

@adampal @kbrock
Could you release a new version?

@neocoin
Copy link

neocoin commented Mar 27, 2023

@adampal @kbrock
plz check this library update.

@kbrock
Copy link
Collaborator

kbrock commented Mar 27, 2023

I just checked, I'm not an owner in gems. That is all @adampal or @flavorjones (the ones that I think are active).
Also, could we merge #268 first? it has generated so many PRs and issues. Just in final review status.

Hmm, this CHANGELOG is going to be a doozy, I'll see if I can spare some cycles and get a PR in for that

@flavorjones
Copy link
Collaborator

@kbrock I'll make you an owner in rubygems -- can you confirm your username or email address for me?

@flavorjones
Copy link
Collaborator

@kbrock You've been invited as an owner on rubygems.org! 🎉

@franzliedke
Copy link

v3.2.0 is out. Thanks, @kbrock! 🎉

(So this can probably be closed now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants