Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Stripe SCA (PSD2) #3288

Closed
dinophile opened this issue Jul 30, 2019 · 6 comments
Closed

Support for Stripe SCA (PSD2) #3288

dinophile opened this issue Jul 30, 2019 · 6 comments

Comments

@dinophile
Copy link

In light of the new changes coming up this autumn we've been in contact with Stripe and are currently working on updates to use their new Payment Intents API.

So far progress completed:

  • Have create/update/get methods
  • Update method takes into account three steps for payment: confirm/capture/cancel
  • Some tests covering common use cases

Still to do:

  • Find all reasonable test cases and flesh out tests for them
  • Confirm QA plan
  • Submit PR

If anyone out there would like to get in touch to help with beta testing that would be great!

Cheers! 😄

@trag-stripe
Copy link

Thanks @dinophile -- Are there beta releases available to point to for testing from this issue and what you're looking for in terms of testing? Perhaps a checklist like @mindlapse wrote

@dinophile
Copy link
Author

@trag-stripe Not quite yet! Still have some cleanup to run and tests to write but hoping to have a branch up soon. I'll get in touch with @mindlapse to get a better idea of what we'd need for QA and will post back here ASAP.

@trag-stripe
Copy link

Ok sounds great - I think a post which lays out specific tasks will get folks willing to take on parts - check out this format for inspiration: tipsi/tipsi-stripe#448 (comment)

@mindlapse
Copy link

We've opened a Discord channel for Active Merchant for collaboration around this topic:
https://discord.gg/kbBQDk7

In terms of a checklist we'll get one set up on this thread, thank you @trag-stripe !

@dinophile
Copy link
Author

So far our list of tasks include:

  • Invoke create_intent method from the authorize method
  • Invoke create_intent method from the purchase method
  • Go through existing tests to see if the following have sufficient coverage:
    • Create Intent test assertions
    • Update Intent test assertions
    • Retrieve Intent test assertions
  • Verify in our test dashboard that the correct behaviour is seen
  • Update documentation needs
    • Need to point to new PI API version
    • Need to inform devs that any async behaviour is their own to manage

Out of scope:

  • Incorporate the SetupIntent API

@dinophile
Copy link
Author

And thanks to @britth for the win! PR submitted already: #3290

Will close this issue and let the PR take over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants