CVE-2024-39908 DoS in REXML

[23tux]

REXML has a CVE

• https://www.ruby-lang.org/en/news/2024/07/16/dos-rexml-cve-2024-39908/
• GHSA-4xqq-m2hx-25v8

I tried updating REXML to 3.3.2 in my fork, but when running the tests I get errors like this

Error: test_failed_create_profile(PaypalTest):
  REXML::ParseException: Malformed XML: Extra content at the end of the document (got '"
  ')
  Line: 28
  Position: 2305
  Last 80 unconsumed characters:
/Users/user/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/rexml-3.3.2/lib/rexml/parsers/baseparser.rb:487:in `pull_event'
/Users/user/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/rexml-3.3.2/lib/rexml/parsers/baseparser.rb:225:in `pull'
/Users/user/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/rexml-3.3.2/lib/rexml/parsers/treeparser.rb:22:in `parse'
/Users/user/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/rexml-3.3.2/lib/rexml/document.rb:448:in `build'
/Users/user/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/rexml-3.3.2/lib/rexml/document.rb:101:in `initialize'
/Users/user/projects/active_merchant/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:481:in `new'
/Users/user/projects/active_merchant/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:481:in `legacy_parse'
/Users/user/projects/active_merchant/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:456:in `parse'
/Users/user/projects/active_merchant/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb:663:in `commit'
/Users/user/projects/active_merchant/lib/active_merchant/billing/gateways/paypal/paypal_recurring_api.rb:33:in `recurring'
/Users/user/projects/active_merchant/test/unit/gateways/paypal_test.rb:400:in `block in test_failed_create_profile'
     397:   def test_failed_create_profile
     398:     @gateway.expects(:ssl_post).returns(failed_create_profile_paypal_response)
     399:     response = assert_deprecation_warning(Gateway::RECURRING_DEPRECATION_MESSAGE) do
  => 400:       @gateway.recurring(@amount, @credit_card, description: 'some description', start_date: Time.now, frequency: 12, period: 'Month')
     401:     end
     402:     assert_instance_of Response, response
     403:     assert !response.success?
/Users/user/projects/active_merchant/test/test_helper.rb:106:in `assert_deprecation_warning'
/Users/user/projects/active_merchant/test/unit/gateways/paypal_test.rb:399:in `test_failed_create_profile'

Any idea how to fix this?

[raymzag]

submitted my attempt #5181 to fix

[github-actions]

To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you!