You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CloseCode::Empty and CloseCode::Status are basically the same code.
According to the RFC, if a client sends no close code (CloseCode::Empty) this is equivalent to 1005 (CloseCode::Status). This can be confusing since it might not be obvious which one of these values you should check against.
I suggest removing CloseCode::Empty and using an Option::None instead.
I would also recommend changing CloseCode::Status to CloseCode::NoStatus to reflect what it actually means.
These are both breaking changes, but if you like them I can make a PR for this.
The text was updated successfully, but these errors were encountered:
The
CloseCode::Empty
andCloseCode::Status
are basically the same code.According to the RFC, if a client sends no close code (
CloseCode::Empty
) this is equivalent to 1005 (CloseCode::Status
). This can be confusing since it might not be obvious which one of these values you should check against.I suggest removing
CloseCode::Empty
and using anOption::None
instead.I would also recommend changing
CloseCode::Status
toCloseCode::NoStatus
to reflect what it actually means.These are both breaking changes, but if you like them I can make a PR for this.
The text was updated successfully, but these errors were encountered: