From 2f5d69172a3f2eed2d2f61b0dfbcc2c4811ea2b6 Mon Sep 17 00:00:00 2001 From: Brennen Bearnes Date: Wed, 10 Oct 2018 14:06:45 -0600 Subject: [PATCH 1/2] catch NotImplementedError when using bitbanged pins On the Pi / CPython, I'm getting NotImplementedError here rather than ValueError. This pull makes the assumption that ValueError is still necessary on CircuitPython. --- adafruit_dotstar.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/adafruit_dotstar.py b/adafruit_dotstar.py index 27e5977..0d5b2ab 100755 --- a/adafruit_dotstar.py +++ b/adafruit_dotstar.py @@ -83,7 +83,8 @@ def __init__(self, clock, data, n, *, brightness=1.0, auto_write=True, pixel_ord while not self._spi.try_lock(): pass self._spi.configure(baudrate=4000000) - except ValueError: + + except (NotImplementedError, ValueError) as e: self.dpin = digitalio.DigitalInOut(data) self.cpin = digitalio.DigitalInOut(clock) self.dpin.direction = digitalio.Direction.OUTPUT From 896a76d4e836e52e7294e2b2f37cbbcebd2f27c1 Mon Sep 17 00:00:00 2001 From: Brennen Bearnes Date: Wed, 10 Oct 2018 14:13:39 -0600 Subject: [PATCH 2/2] remove extraneous `as e` from catch --- adafruit_dotstar.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_dotstar.py b/adafruit_dotstar.py index 0d5b2ab..e2581c9 100755 --- a/adafruit_dotstar.py +++ b/adafruit_dotstar.py @@ -84,7 +84,7 @@ def __init__(self, clock, data, n, *, brightness=1.0, auto_write=True, pixel_ord pass self._spi.configure(baudrate=4000000) - except (NotImplementedError, ValueError) as e: + except (NotImplementedError, ValueError): self.dpin = digitalio.DigitalInOut(data) self.cpin = digitalio.DigitalInOut(clock) self.dpin.direction = digitalio.Direction.OUTPUT