Improvements on datarate, added dataReady function, fixed accelerometer and gyroscope divisor #20
Conversation
…etter Providing data ready function Allow to set gravity constant Removed sleep statement when reading accelerometer, gyroscope and magnetometer Repaired accelerometer_data_rate and gyroscope_data_rate function Updated examples that use data_rate setter Created example measuring data_rate
There was a problem hiding this comment.
Thanks for working on this @uutzinger!
The actions task failed due to code format. If you set up and run pre-commit and then commit the resulting changes to this branch it should help the actions pass that step.
I think don't think we want the build/lib/ directory or the file inside of it to be checked in to the repo. Can you remove that one as well please.
# Conflicts: # adafruit_icm20x.py
There was a problem hiding this comment.
This looks good to me. I tested the existing simpletest and full test scripts on a feather S3 TFT with https://www.adafruit.com/product/4554
I also tested the new example scripts that make use of the data_ready functionality and confirmed the resolution of the outputs changing in Mu serial plotter.
I pushed some commits to merge main, resolve conflicts, and to rename the property to snake case data_ready to be consistent the rest of this library and our others.
Thanks for adding this functionality @uutzinger
Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.1.0 from 2.0.21: > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#20 from uutzinger/main Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.9.2 from 2.9.1: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#120 from indomitableSwan/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Removed sleep() in functions reading accelerometer, gyroscope, magnetometer
Added dataReady function
Fixed accelerometer and gyroscope divisor
Made example for measuring data rate
Updated data_rate settings in examples
Added ability set gravity constant