Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secrets and more #25

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Remove secrets and more #25

merged 1 commit into from
Feb 23, 2025

Conversation

justmobilize
Copy link
Contributor

Remove secrets and more:

  1. change from using secrets.py to os.getenv
  2. switch from checking class names like ESPSPI_WiFiManager to seeing if it has the necessary methods

@justmobilize justmobilize marked this pull request as ready for review February 23, 2025 18:25
@justmobilize
Copy link
Contributor Author

@dhalbert secrets and WiFiManager updates.

dhalbert
dhalbert approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit 8a5620c into adafruit:main Feb 23, 2025
1 check passed
@justmobilize justmobilize deleted the remove-secrets-and-more branch February 23, 2025 20:16
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 24, 2025
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@761055f)
25e3bd4 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 2.0.0 from 1.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_Hue#24 from justmobilize/remove-secrets-and-more

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 3.0.0 from 2.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#25 from justmobilize/remove-secrets-and-more

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 3.0.0 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#105 from justmobilize/secrets-cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justmobilize @dhalbert