From 352151a8468fb65ab0919fcc146aac5585b893c4 Mon Sep 17 00:00:00 2001 From: DJDevon3 <49322231+DJDevon3@users.noreply.github.com> Date: Mon, 22 May 2023 13:10:57 -0400 Subject: [PATCH 1/2] Update import and initializations to current standards Updating examples to 8.0 syntax --- examples/pca9685_calibration.py | 10 ++++------ examples/pca9685_servo.py | 9 +++------ examples/pca9685_simpletest.py | 10 +++++----- 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/examples/pca9685_calibration.py b/examples/pca9685_calibration.py index aaf2d5c..18b4fdb 100644 --- a/examples/pca9685_calibration.py +++ b/examples/pca9685_calibration.py @@ -7,18 +7,16 @@ # speed. import time - -from board import SCL, SDA +import board import busio - -# Import the PCA9685 module. from adafruit_pca9685 import PCA9685 # Create the I2C bus interface. -i2c_bus = busio.I2C(SCL, SDA) +i2c = board.I2C() # uses board.SCL and board.SDA +# i2c = busio.I2C(board.GP1, board.GP0) # Pi Pico RP2040 # Create a simple PCA9685 class instance. -pca = PCA9685(i2c_bus) +pca = PCA9685(i2c) # Set the PWM frequency to 100hz. pca.frequency = 100 diff --git a/examples/pca9685_servo.py b/examples/pca9685_servo.py index fd36193..18d014f 100644 --- a/examples/pca9685_servo.py +++ b/examples/pca9685_servo.py @@ -2,16 +2,13 @@ # SPDX-License-Identifier: MIT import time - -from board import SCL, SDA +import board import busio - -# Import the PCA9685 module. Available in the bundle and here: -# https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 from adafruit_motor import servo from adafruit_pca9685 import PCA9685 -i2c = busio.I2C(SCL, SDA) +i2c = board.I2C() # uses board.SCL and board.SDA +# i2c = busio.I2C(board.GP1, board.GP0) # Pi Pico RP2040 # Create a simple PCA9685 class instance. pca = PCA9685(i2c) diff --git a/examples/pca9685_simpletest.py b/examples/pca9685_simpletest.py index 4d4a06e..48d5a88 100644 --- a/examples/pca9685_simpletest.py +++ b/examples/pca9685_simpletest.py @@ -4,17 +4,17 @@ # This simple test outputs a 50% duty cycle PWM single on the 0th channel. Connect an LED and # resistor in series to the pin to visualize duty cycle changes and its impact on brightness. -from board import SCL, SDA +import time +import board import busio - -# Import the PCA9685 module. from adafruit_pca9685 import PCA9685 # Create the I2C bus interface. -i2c_bus = busio.I2C(SCL, SDA) +i2c = board.I2C() # uses board.SCL and board.SDA +# i2c = busio.I2C(board.GP1, board.GP0) # Pi Pico RP2040 # Create a simple PCA9685 class instance. -pca = PCA9685(i2c_bus) +pca = PCA9685(i2c) # Set the PWM frequency to 60hz. pca.frequency = 60 From fcf077ad6bd5ed4e9c2eff11a1210be6db8a715a Mon Sep 17 00:00:00 2001 From: DJDevon3 <49322231+DJDevon3@users.noreply.github.com> Date: Mon, 22 May 2023 13:49:48 -0400 Subject: [PATCH 2/2] remove unused imports --- examples/pca9685_calibration.py | 1 - examples/pca9685_servo.py | 1 - examples/pca9685_simpletest.py | 7 +++---- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/examples/pca9685_calibration.py b/examples/pca9685_calibration.py index 18b4fdb..3805938 100644 --- a/examples/pca9685_calibration.py +++ b/examples/pca9685_calibration.py @@ -8,7 +8,6 @@ import time import board -import busio from adafruit_pca9685 import PCA9685 # Create the I2C bus interface. diff --git a/examples/pca9685_servo.py b/examples/pca9685_servo.py index 18d014f..f39e377 100644 --- a/examples/pca9685_servo.py +++ b/examples/pca9685_servo.py @@ -3,7 +3,6 @@ import time import board -import busio from adafruit_motor import servo from adafruit_pca9685 import PCA9685 diff --git a/examples/pca9685_simpletest.py b/examples/pca9685_simpletest.py index 48d5a88..7a438a2 100644 --- a/examples/pca9685_simpletest.py +++ b/examples/pca9685_simpletest.py @@ -1,12 +1,11 @@ # SPDX-FileCopyrightText: 2021 ladyada for Adafruit Industries # SPDX-License-Identifier: MIT -# This simple test outputs a 50% duty cycle PWM single on the 0th channel. Connect an LED and -# resistor in series to the pin to visualize duty cycle changes and its impact on brightness. +# Outputs a 50% duty cycle PWM single on the 0th channel. +# Connect an LED and resistor in series to the pin +# to visualize duty cycle changes and its impact on brightness. -import time import board -import busio from adafruit_pca9685 import PCA9685 # Create the I2C bus interface.