Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial unit test, coverage is 97% #26

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

jamesbowman
Copy link
Contributor

Initial unit test in test/unit.py, intended as a basis for further refactoring.

Covers all input combinations, all tests are passing. Using:

pytest tests/unit.py -v --cov --cov-report html

gives coverage around 96%. A few error conditions are not exercised, that's all.

@tannewt
Copy link
Member

tannewt commented Jan 17, 2024

Thanks for the test! Please use pre-commit to ensure the formatting is standardized: https://learn.adafruit.com/improve-your-code-with-pylint/check-your-code-with-pre-commit

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 6a8a224 into adafruit:main Jan 18, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 23, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 1.8.0 from 1.7.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#38 from asmagill/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.5 from 5.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#134 from AdamCummick/correct-mac-error
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#137 from us3r64/fix/wsgiserver
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#139 from us3r64/fix/socket-recv-recv_into

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.8.2 from 2.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#69 from Karel-Kroeze/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniQR to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#28 from jamesbowman/main
  > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#26 from jamesbowman/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants