Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file attinyx16.py update text info please #132

Open
PaulskPt opened this issue Feb 6, 2024 · 0 comments
Open

file attinyx16.py update text info please #132

PaulskPt opened this issue Feb 6, 2024 · 0 comments

Comments

@PaulskPt
Copy link

PaulskPt commented Feb 6, 2024

I am using an Adafruit Gamepad QT (ID 5743).
While diving into this Adafruit_Circuitpython_seesaw module I found that a remark in the file attinyx16.py,
lines 16-19 are not up-to-date. These lines contain currently the following text:

    This class is automatically used by `adafruit_seesaw.seesaw.Seesaw` when
    a ATtinyx16 Breakout (PID 5690, PID 5681) is detected.

    It is also a reference for the capabilities of each pin.

however the code in file seesaw.py, class seesaw init() contains (also) these lines:

        elif (pid in (_5690_PID, _5681_PID, _5743_PID)) or (
            self.chip_id
            in (_ATTINY816_HW_ID_CODE, _ATTINY806_HW_ID_CODE, _ATTINY1616_HW_ID_CODE)

so this code checks also for _5743_PID, which represents the Adafruit Gamepad QT board.

I suggest to change the lines 16-19 in file attinyx16.py into:

    This class is automatically used by `adafruit_seesaw.seesaw.Seesaw` when
    a ATtinyx16 Breakout (PID 5690, PID 5681, PID 5743) is detected.

    It is also a reference for the capabilities of each pin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant