Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to "standard" mode #43

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Dec 2, 2024

@ladyada
Resolves: #40

I tested the 4 examples mentioned in the issue on a cpb+gizmo and all display correctly with this change.

@FoamyGuy FoamyGuy merged commit bc7315d into adafruit:main Dec 4, 2024
1 check passed
@ricknun
Copy link

ricknun commented Dec 4, 2024

When this change is made please include appropriate documentation in your CircuitPython release notes -- This is a big backward compatibility issue. Sometime in the past (when?) the default turtle graphics mode was changed from standard to logo, breaking many existing turtle graphics programs including your own Adafruit examples. I and likely others then wrote programs for the "logo" mode without even knowing about the turtle graphics "mode" setting. Now changing the default from logo back to standard will again break any programs written that assume the default mode is logo. I suggest documenting prominently in your CircuitPython release notes that turtle graphics programs written from to without setting mode() will likely need to have the mode() command added.

@ricknun
Copy link

ricknun commented Dec 4, 2024

"from to without" above should read "from (date1) to (date2) without" -- My use of less-than and greater-than characters was formatted out.

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 5, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#27 from FoamyGuy/type_annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL115A2 to 1.1.18 from 1.1.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL115A2#15 from FoamyGuy/use_ruff
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL115A2#14 from FoamyGuy/type_annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.10 from 4.5.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#98 from michalpokusa/video-streaming-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniQR to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#30 from FoamyGuy/use_ruff
  > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#29 from FoamyGuy/type_annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 3.1.0 from 3.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_turtle#42 from FoamyGuy/standard_color_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_turtle#43 from FoamyGuy/mode_default

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

online turtle graphics example code defects
3 participants