Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies are too broad on PalatformIO #52

Closed
101100 opened this issue Jul 26, 2020 · 1 comment
Closed

Dependencies are too broad on PalatformIO #52

101100 opened this issue Jul 26, 2020 · 1 comment

Comments

@101100
Copy link

101100 commented Jul 26, 2020

The dependencies of the library are too broad. I tried using the library in a PlatformIO project on a Huzzah32 and it would not compile due to the WaveHC dependency that the library does not really need. Even if it did compile, it takes a really long time due to all of the unneeded dependencies.

Specifically here:

Adafruit_LED_Backpack/library.properties

Line 9 in 8ac14ab

depends=Adafruit GFX Library, WaveHC, RTClib, Adafruit GPS Library

this should only be:

depends=Adafruit GFX Library
@ladyada
Copy link
Member

ladyada commented Jul 26, 2020

hihi i think this is fixed in the latest version of PlatformIO that @ivankravets just pushed here
platformio/platformio-core#3607

@ladyada ladyada closed this as completed Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ladyada @101100