Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed ulab spectrogram imports #2336

Merged
merged 3 commits into from
Jan 20, 2024
Merged

fixed ulab spectrogram imports #2336

merged 3 commits into from
Jan 20, 2024

Conversation

evaherrada
Copy link
Collaborator

Fixes #2335

@evaherrada evaherrada requested a review from jepler November 21, 2022 19:16
jepler
jepler reviewed Nov 21, 2022
View reviewed changes
@jepler jepler requested a review from kattni November 21, 2022 20:12
kattni
kattni suggested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jepler Thank you for the tag. @evaherrada Thanks for the fix! Please follow the instructions below. You should not globally disable Black, so you'll do it for each individual section. Please apply these instructions to any obvious section I may have missed (I believe I caught them all).

@evaherrada evaherrada requested a review from kattni November 30, 2022 22:35
@kattni
Copy link
Contributor

kattni commented Nov 30, 2022

@evaherrada CI is failing, but I think I know why.

@kattni
Copy link
Contributor

kattni commented Nov 30, 2022

@caternuson Is this the same failure that was happening previously and fixed by a PR? Does Eva simply need to pull in the changes, and let CI rerun?

@caternuson
Copy link
Contributor

Yep. Need to pull in the changes added with this PR:
#2341

@kattni
Copy link
Contributor

kattni commented Nov 30, 2022

@evaherrada Please check out the link Carter provided here. You need to pull in some recent changes to make the CI pass.

@dhalbert
Copy link
Contributor

@evaherrada Can you finish this off? Thanks.

@TheKitty TheKitty removed the request for review from kattni November 27, 2023 20:12
@TheKitty
Copy link
Collaborator

@jepler is this old news with latest CP versions?

@flavio-fernandes
Copy link
Contributor

/lgtm
still an issue on

dafruit CircuitPython 8.2.9 on 2023-12-06; Adafruit LED Glasses Driver nRF52840 with nRF52840
Board ID:adafruit_led_glasses_nrf52840

@jepler jepler merged commit 4033e68 into main Jan 20, 2024
49 checks passed
@jepler jepler deleted the ulab-spectrogram branch January 20, 2024 21:30
@jepler jepler mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler left review comments

@kattni kattni kattni requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ulab.scipy.signal import spectrogram stopped working with 8.0.0-beta.4
7 participants
@evaherrada @kattni @caternuson @dhalbert @TheKitty @flavio-fernandes @jepler