Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first commit DMX NeoPixel code #2939

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Conversation

jedgarpark
Copy link
Contributor

first commit DMX NeoPixel code

@jedgarpark jedgarpark requested a review from TheKitty December 11, 2024 03:12
Copy link
Collaborator

@TheKitty TheKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jedgarpark
Copy link
Contributor Author

@TheKitty that's a library users will install based on a step in the guide. Is there a procedure for avoiding this error?

@TheKitty
Copy link
Collaborator

TheKitty commented Dec 11, 2024 via email

@jedgarpark
Copy link
Contributor Author

@TheKitty Then it sounds like we either need to tell CI to ignore it or somehow feed CI the library?

@TheKitty
Copy link
Collaborator

@jedgarpark please add SPDX info to the files

@brentru
Copy link
Member

brentru commented Dec 11, 2024

@TheKitty I spent time working with JP. It should be ready for a re-review from you.

Files from the original library are within the repo, with SPDX. We've added .test.skip scripts for all files within the original examples/ folder to optimize the CI runner (we do not need to spend time running other people's example files).

The sketch now builds locally on Uno and on the CI without the need for an externally installed library dependency.

@brentru brentru requested a review from TheKitty December 11, 2024 17:45
@jedgarpark jedgarpark merged commit 4dd60a2 into adafruit:main Dec 11, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants