-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first commit DMX NeoPixel code #2939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheKitty that's a library users will install based on a step in the guide. Is there a procedure for avoiding this error? |
Not that I'm aware of, the CI needs it to test the code
…On Wed, Dec 11, 2024 at 10:41 AM John Edgar Park ***@***.***> wrote:
@TheKitty <https://github.com/TheKitty> that's a library users will
install based on a step in the guide. Is there a procedure for avoiding
this error?
—
Reply to this email directly, view it on GitHub
<#2939 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOSY4FDI4IVQ4U23JXTVB32FBMKNAVCNFSM6AAAAABTMOGJ7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZWGM2DQNJXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
--
Anne Barela
Engineer, Adafruit Industries
***@***.***
|
@TheKitty Then it sounds like we either need to tell CI to ignore it or somehow feed CI the library? |
@jedgarpark please add SPDX info to the files |
@TheKitty I spent time working with JP. It should be ready for a re-review from you. Files from the original library are within the repo, with SPDX. We've added .test.skip scripts for all files within the original The sketch now builds locally on Uno and on the CI without the need for an externally installed library dependency. |
first commit DMX NeoPixel code