Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding cartoon character clock #2967

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

FoamyGuy
Copy link
Collaborator

No description provided.

@TheKitty
Copy link
Collaborator

image

@FoamyGuy
Copy link
Collaborator Author

I've re-arranged the imports in accordance with that rule.

The other pylint errors I've disabled because the if statement logic that already wraps the usage of relavent variables prevents use before assignment, and accessing unsubscriptable values.

This code cannot use with: for the file openings because the file must remain open for longer than 1 context block.

@FoamyGuy
Copy link
Collaborator Author

@TheKitty I think this one is ready for review now.

Some of those pylint options were only in my local version which is a bit newer than the one used by actions here. The latest commit leaves only the ones present in the versions that the check uses.

@FoamyGuy FoamyGuy merged commit ce98c5e into adafruit:main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants