Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacktober issues & fix docs link in list #390

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Remove hacktober issues & fix docs link in list #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5993b4
remove hacktoberfest issue stats from report
FoamyGuy Nov 13, 2024
8fdf437
fix docs links for list.md file
FoamyGuy Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions adabot/circuitpython_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from adabot import pypi_requests as pypi
from adabot.lib import circuitpython_library_validators as cirpy_lib_vals
from adabot.lib import common_funcs
from adabot.lib import assign_hacktober_label as hacktober
from adabot.lib import blinka_funcs
from adabot.lib import bundle_announcer
from adabot import circuitpython_library_download_stats as dl_stats
Expand Down Expand Up @@ -568,20 +567,6 @@ def print_issue_overview(*insights):
len(issue_authors),
)

# print Hacktoberfest labels changes if its Hacktober
in_season, season_action = hacktober.is_hacktober_season()
if in_season:
hacktober_changes = ""
if season_action == "add":
hacktober_changes = "* Assigned Hacktoberfest label to {} issues.".format(
sum([x["hacktober_assigned"] for x in insights])
)
elif season_action == "remove":
hacktober_changes += "* Removed Hacktoberfest label from {} issues.".format(
sum([x["hacktober_removed"] for x in insights])
)
logger.info(hacktober_changes)


# pylint: disable=too-many-branches
def main(verbose=1, output_file=None, validator=None, error_depth=5):
Expand Down
4 changes: 3 additions & 1 deletion adabot/lib/common_funcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ def get_docs_link(bundle_path, submodule):
with open(f"{bundle_path}/{submodule[1]['path']}/README.rst", "r") as readme:
lines = readme.read().split("\n")
for i in range(10):
if "target" in lines[i] and "readthedocs" in lines[i]:
if "target" in lines[i] and (
"readthedocs" in lines[i] or "docs.circuitpython.org" in lines[i]
):
return lines[i].replace(" :target: ", "")
return None
except FileNotFoundError:
Expand Down
Loading