Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: _globals schema nesting #138

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix: _globals schema nesting #138

merged 1 commit into from
Mar 21, 2023

Conversation

joe-allen-89
Copy link
Contributor

Fixes (#137)

Fix

  • Nests globals schema within an _components object.

@joe-allen-89 joe-allen-89 self-assigned this Mar 17, 2023
@joe-allen-89 joe-allen-89 linked an issue Mar 17, 2023 that may be closed by this pull request
Fix nesting on v1 schema _globals #137
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

guywillis
guywillis approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit 6db1bd9 into master Mar 21, 2023
@joe-allen-89 joe-allen-89 deleted the issue/137 branch March 21, 2023 16:42
github-actions bot pushed a commit that referenced this pull request Mar 21, 2023
@semantic-release-bot
Chore(release): 7.4.2 [skip ci]
b899545 
## [7.4.2](v7.4.1...v7.4.2) (2023-03-21)

### Fix

* _globals schema nesting (#138) ([6db1bd9](6db1bd9)), closes [#138](#138)
@github-actions
Copy link

🎉 This PR is included in version 7.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@guywillis guywillis guywillis approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix nesting on v1 schema _globals
4 participants
@joe-allen-89 @oliverfoster @guywillis @cahirodoherty-learningpool