Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise RTL styling #144

Closed
guywillis opened this issue Dec 15, 2023 · 1 comment · Fixed by #145
Closed

Optimise RTL styling #144

guywillis opened this issue Dec 15, 2023 · 1 comment · Fixed by #145
Assignees
@guywillis
Labels
enhancement released

Comments

@guywillis
Copy link
Contributor

Subject of the enhancement

The RTL styling present in the accordion.less file could be optimised a touch better by utilising the margin-inline-start and margin-inline-end properties instead of the current approach.

The margin-inline-start and margin-inline-end properties do not require an associated RTL version as the property inherits the body direction.

Your environment

  • Master
@guywillis guywillis self-assigned this Dec 15, 2023
@guywillis guywillis moved this from New to Assigned in adapt_framework: The TODO Board Dec 15, 2023
@guywillis guywillis mentioned this issue Dec 15, 2023
Merged
@guywillis guywillis changed the title Optimise RTL margin styling Optimise RTL styling Dec 15, 2023
@github-project-automation github-project-automation bot moved this from Assigned to Recently Released in adapt_framework: The TODO Board Dec 19, 2023
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guywillis guywillis

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Updated RTL styling (fixes #144) adaptlearning/adapt-contrib-accordion
1 participant
@guywillis